update about page manifesto section to use reduced padding icons (fix #15679) #15761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wen-2018
added
Needs Review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15761 +/- ##
=======================================
Coverage 79.06% 79.06%
=======================================
Files 160 160
Lines 8355 8355
=======================================
Hits 6606 6606
Misses 1749 1749 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Height is standardized at 15 ✅
Things are lining up a lot better on inline axis ✅
Suggest adding viewBox attribute to SVGs (I believe this helps preserve the aspect ratio in scaling)
Need a bit of clarification on the design expectation for smaller screen vertical spacing before official approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
This PR updates about page hero section to use reduced padding icons to better match the designs
Significant changes and points to review
ltrandrtlIssue / Bugzilla link
#15679
Testing
http://localhost:8000/en-US/about/